FIX: itemsize wrong for date32[day][pyarrow] dtype #57948 #62657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Fixes #57948
Summary
ArrowDtype.itemsize
was incorrectly returning8
bytes fordate32[day]
and otherfixed-width
PyArrow types because it always fell back tonumpy_dtype.itemsize
. This PR uses PyArrow'sbit_width
forfixed-width
types and gracefully falls back tonumpy
forvariable-width
types andbooleans
.Changes
ArrowDtype.itemsize
to usepyarrow_dtype.bit_width
when availableExample
Before:
ArrowDtype(pa.date32()).itemsize == 8
After:
ArrowDtype(pa.date32()).itemsize == 4
Local Environment
NOTE : If additional information required on the local environment, would be happy to provide.